-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON schema specification for search response #1805
Conversation
7918f20
to
6adc50d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to rearrange the schema files and then it should be 👍🏻
@@ -217,7 +217,7 @@ | |||
let(:boundary_geojson) do | |||
{ | |||
"type" => "Feature", | |||
"properties" => {}, | |||
"properties" => nil, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine - just the question about the changes in the sitemap spec
It was until I've now realised that the schema was wrong for this.
so will revert that change |
Description of change
received_at
andstatus
to responseSince we are in the very initial stages of building out this response, keep the schema defined here until it is stable enough to add to the ODP schema
Story Link
https://trello.com/c/dSwLVDaS/2933-priority-2-the-ability-to-specify-that-we-only-receive-applications-marked-as-public-only-makepublic-true