Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON schema specification for search response #1805

Merged
merged 2 commits into from
May 17, 2024
Merged

Conversation

benbaumann95
Copy link
Member

@benbaumann95 benbaumann95 commented May 15, 2024

Description of change

  • Validate response against the search schema
  • Add received_at and status to response

Since we are in the very initial stages of building out this response, keep the schema defined here until it is stable enough to add to the ODP schema

Story Link

https://trello.com/c/dSwLVDaS/2933-priority-2-the-ability-to-specify-that-we-only-receive-applications-marked-as-public-only-makepublic-true

@benbaumann95 benbaumann95 marked this pull request as ready for review May 17, 2024 10:29
@benbaumann95 benbaumann95 force-pushed the make-public branch 3 times, most recently from 7918f20 to 6adc50d Compare May 17, 2024 11:38
Copy link
Member

@pixeltrix pixeltrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to rearrange the schema files and then it should be 👍🏻

@@ -217,7 +217,7 @@
let(:boundary_geojson) do
{
"type" => "Feature",
"properties" => {},
"properties" => nil,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

Copy link
Member

@pixeltrix pixeltrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine - just the question about the changes in the sitemap spec

@benbaumann95
Copy link
Member Author

benbaumann95 commented May 17, 2024

Looks fine - just the question about the changes in the sitemap spec

It was until I've now realised that the schema was wrong for this.
Updated now to

"properties": {
  "type": ["object", "null"]
}

so will revert that change

@benbaumann95 benbaumann95 merged commit b1ebc1a into main May 17, 2024
33 checks passed
@benbaumann95 benbaumann95 deleted the make-public branch May 17, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants