Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workaround for Active Storage misidentifying pdf file blob content type #758

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Add workaround for Active Storage misidentifying pdf file blob content type #758

merged 1 commit into from
Sep 29, 2022

Conversation

benbaumann95
Copy link
Member

@benbaumann95 benbaumann95 commented Sep 29, 2022 •
edited
Loading

Description of change

@benbaumann95 benbaumann95 force-pushed the pdf-content-type-bug-workaround branch from 8f0cb5e to 4797f1d Compare September 29, 2022 09:47
@benbaumann95 benbaumann95 marked this pull request as ready for review September 29, 2022 09:48
notapatch
notapatch approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@notapatch notapatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you noticed that the text for the heading ends up on the next line... "pe as pdf".

I think that means you need to shorten the heading line... snappier.

@benbaumann95
Add workaround for Active Storage misidentifying file content type
62b0be2 
- Bug  with the signature for WMV2
- Magic priority for WMV is 60 but PDF is only 50 https://github.com/rails/marcel/blob/8e285636063d3617df6f73bc73de6574d83a53d5/data/tika.xml#L673-L693
- This workaround will identify a PDF and check to see if the bug is still present before removing the rule
@benbaumann95 benbaumann95 force-pushed the pdf-content-type-bug-workaround branch from 4797f1d to 62b0be2 Compare September 29, 2022 10:07
@benbaumann95 benbaumann95 merged commit b5d8828 into main Sep 29, 2022
@benbaumann95 benbaumann95 deleted the pdf-content-type-bug-workaround branch September 29, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notapatch notapatch notapatch approved these changes

@EGiataganas EGiataganas Awaiting requested review from EGiataganas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benbaumann95 @notapatch