This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
Ledger v2 #288
Merged
Ledger v2 #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bucko13
commented
Feb 27, 2023
humanumbrella
previously requested changes
Feb 27, 2023
* fix: some build system fixes * feat: add tests for ledger address and policy checks * fix: update fixture api for consistent policies * feat: ledger v2 signing support in test suite * chore: some housekeeping
* feat: update args for legerv2 signing * chore: git commit hash into build + footer * fix: cleanup for changes to ledger api * fix: signing real transactions with ledgerv2 * fix: lint errors
| "standard-version": "^9.0.0" | ||
| }, | ||
| "scripts": { | ||
| "build": "npm run check && react-scripts build", | ||
| "build:ci": "npm run ci && react-scripts build", | ||
| "build": "npm run check && REACT_APP_GIT_SHA=`git rev-parse --short HEAD` react-app-rewired build", |
There was a problem hiding this comment.
just confirming we do want this to go out in proper release?
There was a problem hiding this comment.
I assume you're talking about the git commit and not the react-app-rewired, but the answer to both in my opinion is yes. Having the git commit is super useful and not uncommon for open source projects.
nk1tz
previously approved these changes
Feb 27, 2023
Shadouts
suggested changes
Feb 28, 2023
Shadouts
approved these changes
Feb 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Does this PR introduce a breaking change?
Does this PR fix an open issue?