Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-2400] Fix ResponseWriterTestCase failures #1601

Merged
merged 1 commit into from
Jun 13, 2024
Merged

[UNDERTOW-2400] Fix ResponseWriterTestCase failures #1601

merged 1 commit into from
Jun 13, 2024

Conversation

fl4via
Copy link
Member

@fl4via fl4via commented Jun 13, 2024

@fl4via fl4via added enhancement Enhances existing behaviour or code next release This PR will be merged before next release or has already been merged (for payload double check) waiting CI check Ready to be merged but waiting for CI check labels Jun 13, 2024
@fl4via fl4via force-pushed the UNDERTOW-2400 branch 6 times, most recently from addc111 to a85010e Compare June 13, 2024 08:19
@fl4via fl4via added the bug fix Contains bug fix(es) label Jun 13, 2024
@fl4via fl4via force-pushed the UNDERTOW-2400 branch 13 times, most recently from f9ed80d to 3cd4a1f Compare June 13, 2024 13:21
@fl4via fl4via removed the bug fix Contains bug fix(es) label Jun 13, 2024
@fl4via
[UNDERTOW-2400] At AsyncResponseWriterOnPostServlet for servlet tests…
786f839 
…, configure a bigger timeout in the async context, to prevent ci failures caused by slowness in ResponseWriterTestCase.testAsyncRespondBeforeRead

Also, clear the exception field in the superclass ResponseWriterOnPostServlet after reading it, to prevent a non null exception from being read twice, which could cause false test failures

Signed-off-by: Flavia Rainone <[email protected]>
@fl4via fl4via removed the waiting CI check Ready to be merged but waiting for CI check label Jun 13, 2024
@fl4via fl4via merged commit e12bddd into undertow-io:master Jun 13, 2024
34 checks passed
@fl4via fl4via removed the next release This PR will be merged before next release or has already been merged (for payload double check) label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Enhances existing behaviour or code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fl4via