Skip to content

Commit

Permalink
[microsoft#1349] Update the default stack trace format to include val…
Browse files Browse the repository at this point in the history
…ues.

This reduces the number of round-trips to the debugger, because when
values are requested, the `-stack-list-arguments` command also returns
the type of each argument immediately, avoiding the need for
subsequent `-var-create` and `-var-delete` commands to get these
types.
  • Loading branch information
gareth-rees committed Sep 6, 2022
1 parent c594534 commit 50c67ea
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/OpenDebugAD7/AD7DebugSession.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1703,10 +1703,11 @@ protected override async void HandleStackTraceRequestAsync(IRequestResponder<Sta
}
else
{
// No formatting flags provided in the request - use the default format, which includes the module name and argument names / types
// No formatting flags provided in the request - use the default format, which includes the module name and argument names / types / values
flags |= enum_FRAMEINFO_FLAGS.FIF_FUNCNAME_MODULE |
enum_FRAMEINFO_FLAGS.FIF_FUNCNAME_ARGS |
enum_FRAMEINFO_FLAGS.FIF_FUNCNAME_ARGS_TYPES |
enum_FRAMEINFO_FLAGS.FIF_FUNCNAME_ARGS_VALUES |
enum_FRAMEINFO_FLAGS.FIF_FUNCNAME_ARGS_NAMES;
}

Expand Down

0 comments on commit 50c67ea

Please sign in to comment.