Skip to content

Commit

Permalink
test: Fix exception calling setVolume() in ads test (shaka-project#6731)
Browse files Browse the repository at this point in the history
MockAdManager did not define setVolume() in this one test, causing the
test to throw an exception. This exception got swallowed and did not
fail the test, but was noticed in the JS console during a Karma debug
run.
  • Loading branch information
joeyparrish authored May 31, 2024
1 parent 76863f2 commit 89c8361
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions test/ads/ad_manager_unit.js
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,10 @@ describe('Ad manager', () => {
getVolume() {
return 0;
}

setVolume() {
// Nothing
}
};
return new MockAdManager();
};
Expand Down

0 comments on commit 89c8361

Please sign in to comment.