Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sets line-height to 2.0em for hebrew texts #622

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Conversation

theNerd247
Copy link
Contributor

Describe what your pull request addresses

addresses #575

Test Instructions

  • ensure the Hebrew OL card has Hebrew text that is not overlapping

@theNerd247 theNerd247 requested a review from kintsoogi December 27, 2023 20:09
@theNerd247 theNerd247 self-assigned this Dec 27, 2023
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a9a318b) 50.11% compared to head (af7ab5f) 51.67%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #622      +/-   ##
===========================================
+ Coverage    50.11%   51.67%   +1.56%     
===========================================
  Files           43       43              
  Lines         1345     1345              
===========================================
+ Hits           674      695      +21     
+ Misses         671      650      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kintsoogi kintsoogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Hebrew text looks good to me, but all of the other input texts look a little wonky.

For example, the default text within the text inputs on the login page and the account setup page are not vertically centered.

Copy link
Contributor

@kintsoogi kintsoogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out and it seems to space out only the Hebrew text, good work!

@theNerd247 theNerd247 merged commit e4a0a45 into develop Dec 29, 2023
12 checks passed
@theNerd247 theNerd247 deleted the hebrew-css branch December 29, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants