-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix 643/Splitting Source Word Fails #648
Merged
PhotoNomad0
merged 24 commits into
develop
from
mcleanb-643-splitting-source-words-fails.3
May 15, 2024
Merged
Bugfix 643/Splitting Source Word Fails #648
PhotoNomad0
merged 24 commits into
develop
from
mcleanb-643-splitting-source-words-fails.3
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds-fails.3' into mcleanb-643-splitting-source-words-fails.3 # Conflicts: # package.json # yarn.lock
kintsoogi
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
delete-merged-branch
bot
deleted the
mcleanb-643-splitting-source-words-fails.3
branch
May 15, 2024 13:43
PhotoNomad0
added a commit
that referenced
this pull request
Jul 1, 2024
* Upgraded to Next v12, React v18, and Scripture-Tsv v1.2.0 * Upgrade tHelps & bible-ref-range * Bugfix 643/Splitting Source Word Fails (#648) * Upgraded to Next v12, React v18, and Scripture-Tsv v1.2.0 * Update main.yml * Fixed build command * Fixed test command by replacing jest babel with swc * Upgrade tHelps & bible-ref-range -> BETA * Refactor to fix constant redraw of word aligner. Still much cleanup to do. * cleanup. * worked on fixing state. * have aligner area working. * Does not lose split alignments. Now to work on reset. * Moved draggable part of dialog back to WordAlignerDialog * Upgraded to Next v12, React v18, and Scripture-Tsv v1.2.0 * Refactor to fix constant redraw of word aligner. Still much cleanup to do. * cleanup. * worked on fixing state. * have aligner area working. * Does not lose split alignments. Now to work on reset. * Moved draggable part of dialog back to WordAlignerDialog * Cleanup * Cleanup * Cleanup * update word-aligner-rcl * Clean out old code --------- Co-authored-by: kintsoogi <[email protected]> Co-authored-by: Kintsoogi <[email protected]> Co-authored-by: PhotoNomad0 <[email protected]> * Fix linefeed after whitespace (#649) * update scripture-resources-rcl * update scripture-resources-rcl --------- Co-authored-by: PhotoNomad0 <[email protected]> * update scripture-resources-rcl with updated uw-quotes-helper (#651) Co-authored-by: PhotoNomad0 <[email protected]> * reverting translation-helps-rcl (#653) Co-authored-by: PhotoNomad0 <[email protected]> * Tweaks for saving scripture (#654) * update dependencies for save fixes * update dependencies for save fixes --------- Co-authored-by: PhotoNomad0 <[email protected]> * update dependencies for save fixes (#655) Co-authored-by: PhotoNomad0 <[email protected]> * update dependencies for highlight fixes (#656) Co-authored-by: PhotoNomad0 <[email protected]> * Bugfix 642 / fix save of scripture edits (#657) * update dependencies for highlight fixes * update dependencies for scripture save fixes * update dependencies for scripture save fixes * update dependencies for scripture save fixes * update dependencies for scripture save fixes --------- Co-authored-by: PhotoNomad0 <[email protected]> * Bugfix 642 / minimize logging (#658) * update dependencies for scripture save fixes * update dependencies for scripture save fixes * update dependencies for scripture save fixes --------- Co-authored-by: PhotoNomad0 <[email protected]> * rebuild (#659) Co-authored-by: PhotoNomad0 <[email protected]> * Rebuild mcleanb (#660) * rebuild * rebuild --------- Co-authored-by: PhotoNomad0 <[email protected]> --------- Co-authored-by: kintsoogi <[email protected]> Co-authored-by: Kintsoogi <[email protected]> Co-authored-by: PhotoNomad0 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what your pull request addresses
Test Instructions