Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22533 move custom normalization page from Sites to GitHub #2826

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

markusicu
Copy link
Member

Move https://icu.unicode.org/design/normalization/custom
to GitHub Pages markdown at docs/design/normalization/custom.md

Started with https://codebeautify.org/html-to-markdown
followed by fixing lists, headings, links, some code style.

Copied the two tables from the HTML source view of the Sites page, unescaped their HTML, and fiddled a little with the style. Could probably use more work to minimize cell padding/spacing, and we might not need explicit heights and widths -- but I think it's ok for now.

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22533
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

Copy link
Contributor

@echeran echeran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

In the PR preview view, it looks like Github's markdown rendering output might override the table styling with its own styles. This might be orthogonal to how Jekyll deals with things (no overrides) as its generates HTML that gets ultimately served up as-is on the User Guide site.

@markusicu markusicu merged commit 164a56b into unicode-org:main Feb 14, 2024
33 checks passed
@markusicu markusicu deleted the norm-custom-md branch February 14, 2024 17:35
@markusicu
Copy link
Member Author

Thanks, merged. The zero-padding of the tables didn't make it to https://unicode-org.github.io/icu/design/normalization/custom.html :-/

I added the "moved to" link to https://icu.unicode.org/design/normalization/custom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants