Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22532 Trigger CI workflows when workflow definitions change #2848

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

echeran
Copy link
Contributor

@echeran echeran commented Feb 27, 2024

In addition to running C++ tests when C++ code changes, we should also run C++ tests when the configs for the tests change, too.

Also, as a side task, I'm removing the batch: true from the Azure pipelines in the triggers for when merging to main so that Github will show the Azure CI checks alongside the Github Actions CI checks for each merge commit on main.

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22532
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@echeran echeran force-pushed the ci-workflow-edit-trigger branch from 9818196 to f7c6b4e Compare February 27, 2024 17:19
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/workflows/icu_docs.yml is different
  • .github/workflows/icu_valgrind.yml is different
  • .github/workflows/icu4c.yml is different
  • .github/workflows/icu4j.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@echeran
Copy link
Contributor Author

echeran commented Feb 27, 2024

@rp9-next I think the Azure pipeline CI-ICU4J should have been triggered here, just like we have for CI-ICU4C, but it was not. The pipeline yaml file for ICU4J is similar to ICU4C. Do you know what the reason is? Is there something that can be adjusted in the Azure Devops Pipelines dashboard to make it run?

@echeran echeran merged commit 0d7cedc into unicode-org:main Feb 28, 2024
100 checks passed
@echeran echeran deleted the ci-workflow-edit-trigger branch February 28, 2024 17:50
@roubert roubert removed their request for review February 29, 2024 17:58
@rp9-next
Copy link
Contributor

rp9-next commented Mar 4, 2024

@rp9-next I think the Azure pipeline CI-ICU4J should have been triggered here, just like we have for CI-ICU4C, but it was not. The pipeline yaml file for ICU4J is similar to ICU4C. Do you know what the reason is? Is there something that can be adjusted in the Azure Devops Pipelines dashboard to make it run?

@echeran The ICU4J is getting triggered but it does not come up in the GitHub PRs..
https://dev.azure.com/ms/icu/_build/results?buildId=547546&view=results

I think you were mentioning something about adding it to the GitHub settings but couldn't find it..
Could you check if the CI-ICU4J is visible now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants