Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22781 Format Units with Arbitrary Constants #3369

Closed
wants to merge 1 commit into from
Closed

ICU-22781 Format Units with Arbitrary Constants #3369

wants to merge 1 commit into from

Conversation

younies
Copy link
Member

@younies younies commented Feb 5, 2025

Description:

  • Add support for constant denominators in LongNameHandler and MeasureUnitImpl
  • Update NumberFormatterImpl to recognize units with constant denominators
  • Add test case for formatting arbitrary constant units

Checklist

  • Required: Issue filed: ICU-NNNNN
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@younies
ICU-22781 Improve MeasureUnit handling for constant denominators
7f13408 
- Add support for constant denominators in LongNameHandler and MeasureUnitImpl
- Update NumberFormatterImpl to recognize units with constant denominators
- Add test case for formatting arbitrary constant units
@younies younies changed the title ICU-22781 Improve MeasureUnit handling for constant denominators ICU-22781 Format Units with Arbitrary Constants Feb 5, 2025
macchiati
macchiati reviewed Feb 6, 2025
View reviewed changes
Copy link
Member

@macchiati macchiati left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable; didn't approve because it looks like some tests are failing.

@younies
Copy link
Member Author

younies commented Feb 11, 2025

Now , we have this PR: #3381

@younies younies closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macchiati macchiati macchiati left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@younies @macchiati