Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22967 Remove explicit manipultaion of old-xmls.tar.bz2 in workflows #3378

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

mihnita
Copy link
Contributor

@mihnita mihnita commented Feb 7, 2025

The workflow was trying to repair old-xmls.tar.bz2

Which was broken (the first commit in my pull request #3375)
Although the right fix would have been to restore the file for good.
But this "fix" does not work now, on a removed file :-) (the second commit in the mentioned PR)
Anyway... the whole folder 'tools/multi' is not needed, so it should be good now.

Checklist

  • Required: Issue filed: ICU-22967
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

Copy link
Member

@roubert roubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look perfectly reasonable to me and I trust that you've verified that they work.

@mihnita
Copy link
Contributor Author

mihnita commented Feb 7, 2025

Thank you!

@mihnita mihnita merged commit e8c179d into unicode-org:main Feb 7, 2025
102 checks passed
@mihnita mihnita deleted the mihai_fix_lfs branch February 13, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants