Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.rs compatible datagen api #1188

Closed
devsnek opened this issue Oct 19, 2021 · 3 comments
Closed

build.rs compatible datagen api #1188

devsnek opened this issue Oct 19, 2021 · 3 comments
Assignees
Labels
C-data-infra Component: provider, datagen, fallback, adapters S-medium Size: Less than a week (larger bug fix or enhancement) T-core Type: Required functionality

Comments

@devsnek
Copy link

devsnek commented Oct 19, 2021

I think it would be nice if icu4x provided an api you could call from your build.rs for generating the data your app needs instead of having to clone the repo and run a cli command. it could also do stuff like automatically emitting the cargo:rerun-if-changed things for the generated files.

@sffc sffc self-assigned this Oct 19, 2021
@sffc sffc added C-data-infra Component: provider, datagen, fallback, adapters S-medium Size: Less than a week (larger bug fix or enhancement) T-core Type: Required functionality labels Oct 19, 2021
@sffc sffc added this to the ICU4X 0.5 milestone Oct 19, 2021
@sffc sffc assigned robertbastian and unassigned sffc Jan 27, 2022
@sffc
Copy link
Member

sffc commented Jan 27, 2022

The mechanism here should be a postcard blob or json file system with a build.rs file that makes a Crabbake data file.

@sffc sffc added the backlog label Jan 27, 2022
@sffc sffc removed this from the ICU4X 0.5 milestone Jan 27, 2022
@sffc sffc added the v1 label Jan 27, 2022
@robertbastian
Copy link
Member

I think this request is independent of Crabbake. Having a library version of the datagen binary that could be wired to a crate's build.rs does make things a lot easier than downloading the datagen crate and manually generating the data.

@robertbastian robertbastian added this to the 2022 Q2 0.6 Sprint F milestone Mar 31, 2022
@sffc sffc removed v1 labels Apr 1, 2022
@sffc
Copy link
Member

sffc commented Apr 1, 2022

I think the deliverable here is to build a sample project using a build.rs file and document it with a tutorial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-data-infra Component: provider, datagen, fallback, adapters S-medium Size: Less than a week (larger bug fix or enhancement) T-core Type: Required functionality
Projects
None yet
Development

No branches or pull requests

3 participants