Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datagen API #1819

Merged
merged 9 commits into from
Apr 28, 2022
Merged

Datagen API #1819

merged 9 commits into from
Apr 28, 2022

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Apr 27, 2022 •
edited
Loading

Part of #1188

@robertbastian robertbastian changed the title Datagenlib Datagen API Apr 27, 2022
Manishearth
Manishearth reviewed Apr 27, 2022
View reviewed changes
provider/datagen/Cargo.toml
@@ -22,6 +22,7 @@ include = [
"LICENSE",
"README.md",
]
default-run = "icu4x-datagen"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL!

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • provider/datagen/src/bin/datagen.rs is different
  • provider/datagen/src/lib.rs is different
  • provider/datagen/src/transform/cldr/serde/aliases.rs is different
  • provider/datagen/src/transform/cldr/serde/likely_subtags.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • Cargo.lock is different
  • provider/datagen/src/main.rs is different
  • provider/testdata/Cargo.toml is no longer changed in the branch
  • provider/testdata/data/cldr/cldr-core/supplemental/metaZones.json is no longer changed in the branch
  • provider/testdata/README.md is no longer changed in the branch
  • provider/testdata/src/bin/download-sources.rs is no longer changed in the branch
  • provider/testdata/src/lib.rs is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@robertbastian robertbastian marked this pull request as ready for review April 27, 2022 11:41
@robertbastian robertbastian requested review from sffc and a team as code owners April 27, 2022 11:41
sffc
sffc reviewed Apr 27, 2022
View reviewed changes
provider/datagen/src/lib.rs Outdated Show resolved Hide resolved
provider/datagen/src/lib.rs Show resolved Hide resolved
Manishearth
Manishearth previously approved these changes Apr 27, 2022
View reviewed changes
provider/datagen/README.md Outdated Show resolved Hide resolved
provider/datagen/src/bin/datagen.rs Show resolved Hide resolved
provider/datagen/src/lib.rs Show resolved Hide resolved
provider/datagen/src/lib.rs Outdated Show resolved Hide resolved
Manishearth
Manishearth previously approved these changes Apr 27, 2022
View reviewed changes
@robertbastian robertbastian requested a review from sffc April 27, 2022 16:25
sffc
sffc requested changes Apr 27, 2022
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just some small things

provider/datagen/src/transform/cldr/calendar/japanese.rs Outdated Show resolved Hide resolved
provider/datagen/src/transform/cldr/datetime/mod.rs Outdated Show resolved Hide resolved
provider/datagen/src/transform/cldr/serde/aliases.rs Outdated Show resolved Hide resolved
provider/datagen/src/transform/cldr/serde/numbers.rs Outdated Show resolved Hide resolved
provider/datagen/src/transform/uprops/enum_uniset.rs Outdated Show resolved Hide resolved
provider/datagen/src/transform/uprops/mod.rs Outdated Show resolved Hide resolved
provider/datagen/src/transform/uprops/script.rs Outdated Show resolved Hide resolved
@jedel1043 jedel1043 mentioned this pull request Apr 28, 2022
Closed
@robertbastian robertbastian merged commit bb3e2ec into unicode-org:main Apr 28, 2022
@robertbastian robertbastian deleted the datagenlib branch April 28, 2022 09:30
@hsivonen hsivonen mentioned this pull request May 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

@Manishearth Manishearth Awaiting requested review from Manishearth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertbastian @sffc @Manishearth