-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DateTime entry point data #240
Comments
|
In #301 I'm renaming away from @sffc said he wants to write a short doc about trait and struct considerations for future implementers of a concrete type. I'd like to ask @nciric @mihnita and @sffc to also review https://github.com/unicode-org/icu4x/blob/master/components/datetime/src/date.rs#L33-L40 and let me know what changes they'd like to see in the type for 0.1. I will add them with @mihnita brought up |
I think that calendar info is needed, probably timezone. A DateTime class without calendar info is like a currency expressed as in integer (without the currency code) I think that the ECMAScript Temporal is a good model. But it is a bit too complex to try to capture for 0.1 (there is For us, if we add info on calendar and timezone (and millisecond), all in the Data types (Shane?): calendar & timezone will probably need to be classes, with strings for id. Making them directly classes would means that we are betting that this is the direction Rust will go, when it gets to solving this problem. And we don't know that. |
We ended up working on two documents. Shane is working on a more detailed explanation for the requirements for the API, while I wrote a shorter "intro" doc for the Rust community to the problem scope and the role of ICU4X in it - https://github.com/unicode-org/icu4x/wiki/Rust-Date-and-Time-API-Request My doc will be updated to link to Shane's. |
Shane added https://github.com/unicode-org/icu4x/blob/master/docs/datetime-input.md . With those two, I consider it done! |
For the initial release of
DateTimeFormat
, we'd like to ensure that we understand what data we'd like the futureDateTime
struct to provide.For 0.1 release my plan is to include some
DummyDateTime
orMockDateTime
as part oficu-datetime
crate which will be a very minimal mock, but with the right information.This will allow us to present the formatter and enable the Rust community to work on date/time management API that will contain the correct data we need to format it properly.
In particular, @sffc pointed out that we'll likely want the calendar information to be included.
The text was updated successfully, but these errors were encountered: