Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DummyDateTime to MockDateTime #301

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

zbraniecki
Copy link
Member

This is a pure rename to get rid of the Dummy term.

I remember there were multiple options floating around. If you can settle on a different word than Mock, I'm happy to use it. If not, I suggest we land with Mock.

@zbraniecki zbraniecki requested review from sffc and mihnita October 5, 2020 23:50
@zbraniecki zbraniecki requested a review from a team as a code owner October 5, 2020 23:50
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9c562dac626b52ef9097ac16d1532e476dedb0de-PR-301

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.169%

Totals Coverage Status
Change from base Build 554b3b5669a54b7694ceea49730e71bef4c5998d: 0.0%
Covered Lines: 2886
Relevant Lines: 3692

💛 - Coveralls

@zbraniecki zbraniecki merged commit 6d6bcea into unicode-org:master Oct 6, 2020
@zbraniecki zbraniecki deleted the date-name branch October 19, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants