Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for linting #84

Closed
sffc opened this issue May 13, 2020 · 5 comments · Fixed by #94
Closed

Add CI for linting #84

sffc opened this issue May 13, 2020 · 5 comments · Fixed by #94
Assignees
Labels
C-test-infra Component: Integration test infrastructure T-core Type: Required functionality
Milestone

Comments

@sffc
Copy link
Member

sffc commented May 13, 2020

Things we should cover in a linting CI:

  1. Code format is consistent with cargo fmt
  2. Copyright headers are correct
@sffc sffc added T-core Type: Required functionality C-test-infra Component: Integration test infrastructure labels May 13, 2020
@sffc
Copy link
Member Author

sffc commented May 13, 2020

@echeran @zbraniecki

@zbraniecki
Copy link
Member

Yep! Later we can consider clippy. Clippy has false-positives, so it requires some one-off cases to turn it off, but it generally helps avoid mistakes that cost perf/mem and the hints are ~90% useful in my experience.

@echeran echeran linked a pull request May 15, 2020 that will close this issue
@echeran
Copy link
Contributor

echeran commented May 15, 2020

How exactly should the copyright headers check go? Check that every file has copyright headers? Check that we're not adding code with copyright headers?

@sffc
Copy link
Member Author

sffc commented May 15, 2020

@hsivonen What is the correct strategy for license headers in code files in ICU4X?

@sffc
Copy link
Member Author

sffc commented May 22, 2020

Ping @hsivonen about copyright headers

@echeran echeran removed a link to a pull request Jun 9, 2020
@echeran echeran mentioned this issue Jun 9, 2020
@sffc sffc added this to the 2020 Q2 milestone Jun 17, 2020
@echeran echeran linked a pull request Jun 25, 2020 that will close this issue
@echeran echeran closed this as completed Jun 25, 2020
@echeran echeran removed a link to a pull request Jun 25, 2020
@echeran echeran linked a pull request Jun 25, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-test-infra Component: Integration test infrastructure T-core Type: Required functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants