Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI copyright headers check #155

Closed
echeran opened this issue Jun 25, 2020 · 1 comment · Fixed by #252 or #381
Closed

Add CI copyright headers check #155

echeran opened this issue Jun 25, 2020 · 1 comment · Fixed by #252 or #381
Assignees
Labels
C-process Component: Team processes T-task Type: Tracking thread for a non-code task

Comments

@echeran
Copy link
Contributor

echeran commented Jun 25, 2020

This task is split off from #84 to represent just the requirement of doing checks on copyright headers on source files.

We want every file to have headers indicating that indicates that the file is a part of ICU4X and references a link to the license.

Anything else I'm missing? @hsivonen

@echeran echeran added T-task Type: Tracking thread for a non-code task C-process Component: Team processes discuss Discuss at a future ICU4X-SC meeting labels Jun 25, 2020
@echeran echeran self-assigned this Jun 25, 2020
@echeran echeran added this to the 2020 Q3 milestone Jun 25, 2020
@sffc sffc removed the discuss Discuss at a future ICU4X-SC meeting label Jul 10, 2020
@echeran echeran added the discuss Discuss at a future ICU4X-SC meeting label Aug 6, 2020
@sffc sffc removed the discuss Discuss at a future ICU4X-SC meeting label Aug 6, 2020
@hsivonen
Copy link
Member

I created a PR that updates CONTRIBUTING.md to document the license header language that was discussed.

For CI, this means checking that .rs files start with

// This file is part of ICU4X. For terms of use, please see the file
// called LICENSE at the top level of the ICU4X source tree
// (online at: https://github.com/unicode-org/icu4x/blob/master/LICENSE ).

and .toml files start with

# This file is part of ICU4X. For terms of use, please see the file
# called LICENSE at the top level of the ICU4X source tree
# (online at: https://github.com/unicode-org/icu4x/blob/master/LICENSE ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-process Component: Team processes T-task Type: Tracking thread for a non-code task
Projects
None yet
3 participants