Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style Guide revision 2 #142

Merged
merged 6 commits into from
Jun 25, 2020
Merged

Style Guide revision 2 #142

merged 6 commits into from
Jun 25, 2020

Conversation

zbraniecki
Copy link
Member

Fixes #112.

I shied away from extending the errors bit because the changes are large enough as is, and I'd prefer to keep #118 for another revision later.

@zbraniecki
Style Guide revision 2
edfd416 
Fixes #112.

I shied away from extending the `errors` bit because the changes are large enough as is, and I'd prefer to keep #118 for another revision later.
@zbraniecki zbraniecki requested review from hagbard and sffc June 20, 2020 20:27
@zbraniecki zbraniecki requested a review from a team as a code owner June 20, 2020 20:27
@zbraniecki zbraniecki self-assigned this Jun 20, 2020
@coveralls
Copy link

coveralls commented Jun 20, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 06852275771daae94176f41bc9291525e3727753-PR-142

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.199%
Totals Coverage Status
Change from base Build 48b82b24f31f51cba761f65030c684b371c5dcd6: 0.0%
Covered Lines: 688
Relevant Lines: 789
💛 - Coveralls

Manishearth
Manishearth previously approved these changes Jun 21, 2020
View reviewed changes
@sffc
Copy link
Member

sffc commented Jun 22, 2020

Were you planning to discuss the (non) builder pattern?

@zbraniecki
Copy link
Member Author

Were you planning to discuss the (non) builder pattern?

No, since we decided to go with options struct, I recommended it for constructors. Why would I list a pattern we don't want to promote?

sffc
sffc reviewed Jun 22, 2020
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; for some reason I wasn't seeing all the diffs. I now see the section where you're documenting the recommendation to use an options bag.

docs/style-guide.md Show resolved Hide resolved
docs/style-guide.md Outdated Show resolved Hide resolved
docs/style-guide.md Show resolved Hide resolved
@zbraniecki
Copy link
Member Author

Thanks! Updated to your comments!

@zbraniecki zbraniecki requested a review from sffc June 22, 2020 22:21
sffc
sffc reviewed Jun 22, 2020
View reviewed changes
docs/style-guide.md Outdated Show resolved Hide resolved
docs/style-guide.md Show resolved Hide resolved
docs/style-guide.md Outdated Show resolved Hide resolved
docs/style-guide.md Outdated Show resolved Hide resolved
@zbraniecki zbraniecki requested a review from sffc June 23, 2020 18:26
@zbraniecki
Copy link
Member Author

Thanks. Ready for re-review.

sffc
sffc reviewed Jun 24, 2020
View reviewed changes
docs/style-guide.md Show resolved Hide resolved
docs/style-guide.md Outdated Show resolved Hide resolved
docs/style-guide.md Outdated Show resolved Hide resolved
docs/style-guide.md Outdated Show resolved Hide resolved
@zbraniecki
Copy link
Member Author

Ready for re-review.

@zbraniecki zbraniecki requested a review from sffc June 25, 2020 02:22
@zbraniecki zbraniecki mentioned this pull request Jun 25, 2020
Merged
@zbraniecki zbraniecki merged commit adeae53 into master Jun 25, 2020
@zbraniecki zbraniecki deleted the style-guide-rev2 branch June 25, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth left review comments

@sffc sffc sffc approved these changes

@hagbard hagbard Awaiting requested review from hagbard

Assignees

@zbraniecki zbraniecki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design Doc - Explicit/Implicit and Builder Patterns
4 participants
@zbraniecki @coveralls @sffc @Manishearth