Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style guide: Add error test coverage, integer overflow, and no_std. #154

Merged
merged 2 commits into from
Jun 30, 2020
Merged

Style guide: Add error test coverage, integer overflow, and no_std. #154

merged 2 commits into from
Jun 30, 2020

Conversation

sffc
Copy link
Member

@sffc sffc commented Jun 25, 2020

Fixes #77
Fixes #118
Fixes #126

@sffc sffc requested a review from a team as a code owner June 25, 2020 22:01
@coveralls
Copy link

coveralls commented Jun 25, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 9441b15361e087539ee9bc368b3f0670828f11bc-PR-154

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.199%
Totals Coverage Status
Change from base Build adeae539831ace2392ee4a9cdc9c3c1e47da71ea: 0.0%
Covered Lines: 688
Relevant Lines: 789
💛 - Coveralls

zbraniecki
zbraniecki previously approved these changes Jun 25, 2020
View reviewed changes
docs/style-guide.md Outdated Show resolved Hide resolved
@sffc sffc mentioned this pull request Jun 25, 2020
Closed
@sffc
Copy link
Member Author

sffc commented Jun 26, 2020

@Manishearth @hagbard I believe this PR is consistent with our previous discussions and decisions. I plan to merge this PR on Monday morning.

@sffc sffc merged commit e555f25 into unicode-org:master Jun 30, 2020
@sffc sffc deleted the styleguide branch June 30, 2020 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbraniecki zbraniecki zbraniecki approved these changes

@hagbard hagbard Awaiting requested review from hagbard

@Manishearth Manishearth Awaiting requested review from Manishearth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sffc @coveralls @zbraniecki