Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Dates support for FsDataProviderExport (based on #258) #261

Merged
merged 3 commits into from
Sep 23, 2020
Merged

Adds Dates support for FsDataProviderExport (based on #258) #261

merged 3 commits into from
Sep 23, 2020

Conversation

zbraniecki
Copy link
Member

Based on #258 this adds support for exporting dates key in FsDataProviderExport.

@zbraniecki zbraniecki requested review from sffc and a team as code owners September 22, 2020 02:37
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • components/data-provider/src/data_key.rs is no longer changed in the branch
  • components/data-provider/src/structs/dates.rs is no longer changed in the branch
  • components/data-provider/src/structs/mod.rs is no longer changed in the branch
  • components/data-provider/src/structs/plurals.rs is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@zbraniecki

This comment has been minimized.

Sign in to view
@coveralls
Copy link

coveralls commented Sep 22, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build acfb94dc3b30b3adc879821f540df50bd668d88f-PR-261

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+6.07%) to 89.008%
Changes Missing Coverage Covered Lines Changed/Added Lines %
components/fs-data-provider/src/bin/icu4x-cldr-export.rs 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
components/fs-data-provider/src/bin/icu4x-cldr-export.rs 1 0%
components/locale/src/langid.rs 5 0%
Totals Coverage Status
Change from base Build ab00f54f6ce0fd898a6f8a6d70e77a24926a3dcd: 6.07%
Covered Lines: 1660
Relevant Lines: 1865
💛 - Coveralls

@zbraniecki zbraniecki added this to the ICU4X 0.1 milestone Sep 22, 2020
@zbraniecki zbraniecki self-assigned this Sep 22, 2020
@zbraniecki zbraniecki mentioned this pull request Sep 22, 2020
Closed
@zbraniecki
Copy link
Member Author

The error has been fixed in the previous PR. This PR is ready for review!

sffc
sffc previously approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the understanding that most of this PR is already covered by #258!

components/cldr-json-data-provider/src/transform/mod.rs
if let Some(result) = self.dates.try_load(req, &self.cldr_paths)? {
return Ok(result);
}
Err(DataError::UnsupportedDataKey(req.data_key))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing the DataEntryCollection fix that I see in #258

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on top of the current #258.

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • components/cldr-json-data-provider/src/transform/dates.rs is different
  • components/cldr-json-data-provider/src/transform/mod.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@zbraniecki zbraniecki requested a review from sffc September 22, 2020 19:04
@zbraniecki zbraniecki merged commit 2a4da75 into unicode-org:master Sep 23, 2020
@zbraniecki zbraniecki deleted the datetime-provider-fs branch October 19, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

Assignees

@zbraniecki zbraniecki

Labels
None yet
Projects
None yet
Milestone
ICU4X 0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@zbraniecki @coveralls @sffc