Moving datagen options to export
#3784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(letting shane review locale filtering, I can but I'm less familiar with the code) |
sffc
previously approved these changes
Aug 4, 2023
| @@ -42,12 +42,11 @@ use std::collections::HashSet; | |||
| #[non_exhaustive] | |||
| #[derive(Debug, Clone, PartialEq, Default)] | |||
| pub struct Options { | |||
| /// The set of keys to generate. See [`icu_datagen::keys`], | |||
| /// [`icu_datagen::all_keys`], [`icu_datagen::key`] and [`icu_datagen::keys_from_bin`]. | |||
| pub keys: HashSet<icu_provider::DataKey>, | |||
There was a problem hiding this comment.
Observation (pre-existing issue): this means Options is not Copy, which means we won't benefit from non-exhaustive spread syntax once it becomes available.
There was a problem hiding this comment.
The locales, segmentation_models, and collations fields are collections already.
There was a problem hiding this comment.
(Yeah, which is why my comment is "observation pre-existing")
We should probably discuss this choice especially before we ship this API
sffc
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also necessarily moves the locale filtering from
supported_localesintoexport, and resolves #3409.Part of #3487.
Resolves most todos in #3640 (comment)