Add some safety comments #4288
Merged
Add some safety comments #4288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
requested review from
zbraniecki and
robertbastian
as code owners
robertbastian
approved these changes
Nov 14, 2023
| @@ -148,7 +148,11 @@ impl LocaleFallbacker { | |||
| parents: crate::provider::Baked::SINGLETON_FALLBACK_PARENTS_V1, | |||
| collation_supplement: Some(crate::provider::Baked::SINGLETON_FALLBACK_SUPPLEMENT_CO_V1), | |||
| }; | |||
| // Shitty covariance because the zeromaps confuse the compiler | |||
| // Safety: we're transmuting down from LocaleFallbackerBorrowed<'static> to LocaleFallbackerBorrowed<'a> | |||
There was a problem hiding this comment.
wait, you think my comment wasn't accurate enough 😀 ?
There was a problem hiding this comment.
trying to make it understandable for people less familiar with this stuff
There was a problem hiding this comment.
I understand, this was meant as a light-hearted joke
sffc
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caught during unsafe review