Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rust toolchain to 1.74 #4363

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Update Rust toolchain to 1.74 #4363

merged 2 commits into from
Nov 27, 2023

Conversation

westy92
Copy link
Contributor

@westy92 westy92 commented Nov 24, 2023

Update Rust toolchain to 1.74.

@westy92 westy92 requested a review from a team as a code owner November 24, 2023 16:41
Manishearth
Manishearth approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine from a code pov.

AIUI we don't have restrictions on bumping our default CI toolchain, yes? Ideally the CI nightly is bumped to something close to the nightly that became 1.74.

(provided all CI passes with the LLVM versions)

robertbastian
robertbastian approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@robertbastian robertbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally the CI nightly is bumped to something close to the nightly that became 1.74.

We don't do this anymore, as we want to be on latest stable Rust but not on latest stable LLVM, which is required for nightly tricks.

@robertbastian robertbastian merged commit 3df24f4 into unicode-org:main Nov 27, 2023
28 checks passed
@sffc sffc removed their request for review November 28, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertbastian robertbastian robertbastian approved these changes

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@westy92 @Manishearth @robertbastian