Audit self by-copy vs by-ref on Borrowed types #5977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
requested review from
sffc,
robertbastian,
hsivonen,
echeran,
zbraniecki and
a team
as code owners
Manishearth
changed the title
Manishearth
force-pushed
the
borrowed-types
branch
from
d7c2fd6 to
11bc4e1
Compare
sffc
previously approved these changes
Jan 10, 2025
|
Did you check whether we should switch back to |
I went through all of the Borrowed impls, yes. |
Manishearth
force-pushed
the
borrowed-types
branch
from
11bc4e1 to
fd49426
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5921
We should also land #5975