Add ZeroVec ULE impls for TinyStr #710
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
I tested that the endianness works via |
Pull Request Test Coverage Report for Build ce6ee660b133e4e2862016bbad6213f4372ddc86-PR-710
💛 - Coveralls |
sffc
reviewed
May 10, 2021
| @@ -24,6 +24,7 @@ include = [ | |||
| [dependencies] | |||
| either = "1.6.1" | |||
| serde = { version = "1.0", optional = true } | |||
| tinystr = { version = "0.4.5", optional = true } | |||
There was a problem hiding this comment.
Question: Why did you do it in this direction? I thought we discussed that this should be done in the opposite direction, with tinystr depending on zerovec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #652