-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace DataPayload Deref with .get() throughout ICU4X #739
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code is sane and looks good.
suggestion, non blocking
: I strongly believe borrow
is a better name here than get
.
Codecov Report
@@ Coverage Diff @@
## main #739 +/- ##
==========================================
+ Coverage 74.57% 74.62% +0.04%
==========================================
Files 178 178
Lines 10719 10715 -4
==========================================
+ Hits 7994 7996 +2
+ Misses 2725 2719 -6
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 7baff248eab647aa9c4204bcc56d01a6780c8adc-PR-739
💛 - Coveralls |
There are some things I like about
|
I'm going to use admin privileges to merge this since I got two LGTMs and my latest push only changes a README file; you can find the diff here: |
Follow-up for the naming discussion: #740 |
See #667