Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy CONTRIBUTING.md from unicode-org template #2

Closed
wants to merge 1 commit into from
Closed

Copy CONTRIBUTING.md from unicode-org template #2

wants to merge 1 commit into from

Conversation

markusicu
Copy link
Member

srl295
srl295 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@srl295 srl295 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however this is only necessary if you're planning to add to CONTRIBUTING.md, though, because by default you already get the inherited version (the URL is in the README and it is presented to users automatically when they open a PR).

If you're not planning on making any additional sections to this file, then there's no reason to copy it here.

@markusicu
Copy link
Member Author

LGTM, however this is only necessary if you're planning to add to CONTRIBUTING.md, though, because by default you already get the inherited version (the URL is in the README and it is presented to users automatically when they open a PR).

If you're not planning on making any additional sections to this file, then there's no reason to copy it here.

Ok, I just assumed that a public repo should have a local copy of that file, so before making this repo public (as was approved) I was looking for what might still need to be done.

I will revert this then.

I haven't tried yet whether I have the power to make this repo public. I guess I will find out :-)

Do we have instructions for how to set up a new public repo? For example, how to set up the CLA assistant? The “... Internal Policies & Processes ...” doc says “Github does not make the CLA Assistant available in private repos”. Does it get auto-added when making the repo public?

@markusicu
Copy link
Member Author

Do we have instructions for how to set up a new public repo?

@srl295 In addition to the CLA setup, it would also be useful to document the need-no-local-contributing-file, the recommended branch protections, recommended repo settings in general, ...

The “Policy & Process for New Repos ...” doc does not seem to provide these details either. But maybe I am just blind.

@nciric
Copy link
Contributor

nciric commented Feb 23, 2024 via email

@nciric
Copy link
Contributor

nciric commented Feb 23, 2024 via email

@markusicu
Copy link
Member Author

Or do we need to do more set up work to do so (like CLA requirement)?

Well, I just made it public, but when I go back to the branch protections, there are no "status checks" to select.
@srl295 how do I set up the CLA assistant "status check"?

PS @nciric: It's much nicer to reply to GitHub comments from the GitHub UI. Replying by email is messy.

@srl295
Copy link
Member

srl295 commented Feb 23, 2024

LGTM, however this is only necessary if you're planning to add to CONTRIBUTING.md, though, because by default you already get the inherited version (the URL is in the README and it is presented to users automatically when they open a PR).
If you're not planning on making any additional sections to this file, then there's no reason to copy it here.

Ok, I just assumed that a public repo should have a local copy of that file, so before making this repo public (as was approved) I was looking for what might still need to be done.

Mostly just setting up the README and such.

I will revert this then.

or close it?

I haven't tried yet whether I have the power to make this repo public. I guess I will find out :-)

probably not, if not just let me know.

Do we have instructions for how to set up a new public repo? For example, how to set up the CLA assistant? The “... Internal Policies & Processes ...” doc says “Github does not make the CLA Assistant available in private repos”. Does it get auto-added when making the repo public?

The only instructions are to update the README which I've done.

CLA assistant is already setup organization wide, there's nothing that needs to be done there, other than branch protection to require PRs to pass the cla-assistant check. But i'd come knocking on the door here if that wasn't in place.

@markusicu
Copy link
Member Author

I haven't tried yet whether I have the power to make this repo public. I guess I will find out :-)

probably not, if not just let me know.

I did make it public.

CLA assistant is already setup organization wide, there's nothing that needs to be done there, other than branch protection to require PRs to pass the cla-assistant check. But i'd come knocking on the door here if that wasn't in place.

I went back to the main branch protections and tried to turn on “Require status checks to pass before merging” but got

  • No status checks found
  • Sorry, we couldn’t find any status checks in the last week for this repository.

Is that expected because we do this for the whole org, not for each repo?

@markusicu markusicu closed this Feb 23, 2024
@markusicu markusicu deleted the markusicu-initial-contributing branch February 23, 2024 19:38
@srl295
Copy link
Member

srl295 commented Feb 23, 2024

Or do we need to do more set up work to do so (like CLA requirement)?

Well, I just made it public, but when I go back to the branch protections, there are no "status checks" to select.

@srl295 how do I set up the CLA assistant "status check"?

Someone will have to open a PR so that it attempts to run the check.

The status checks to select option says something like "checks seen during the last week".

@nciric nciric mentioned this pull request Feb 27, 2024
Open
@macchiati macchiati mentioned this pull request Mar 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srl295 srl295 srl295 approved these changes

@nciric nciric Awaiting requested review from nciric

@annebright annebright Awaiting requested review from annebright

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markusicu @nciric @srl295