Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whither 13.1.0? #100

Open
srl295 opened this issue Jul 16, 2021 · 4 comments
Open

Whither 13.1.0? #100

srl295 opened this issue Jul 16, 2021 · 4 comments

Comments

@srl295
Copy link
Member

srl295 commented Jul 16, 2021

#44 introduces a "13.1.0" data subdirectory. Perhaps it means Emoji 13.1.0 as opposed to Unicode 13.1.0. Revisit whether 13.1.0 can be removed from the data directory.

Should the emoji version be kept separately from the Unicode version?

@macchiati
Copy link
Member

macchiati commented Jul 16, 2021 via email

@markusicu
Copy link
Member

We should not need fake UCD 13.1 files for processing emoji 13.1.

I think we should not need a fake 13.1 value for UCD property Age either.

We should revisit the code for these after Unicode 14.

srl295 added a commit to macchiati/unicodetools that referenced this issue Jul 17, 2021
- TODOs around 13.1 irregularities (unicode-org#100)
- explaining why there is a CheckEmojiProps2.java
- improving tool output
@macchiati
Copy link
Member

macchiati commented Jul 17, 2021 via email

srl295 added a commit to macchiati/unicodetools that referenced this issue Jul 17, 2021
- a few fixes also for UTS unicode-org#18.
- Note that the easiest way to support U13 and E13.1 was to copy some extra
files into idna/13.1 and security/13.1 (to revisit in unicode-org#100)
- Clarify where getTrueSet() can't be called
- Work around getTrueSet() exception for UNKNOWN type data
- Add CheckEmojiProps2.java (work around name conflict)
- improve tool output

Co-authored-by: Markus Scherer <[email protected]>
Co-authored-by: Steven R. Loomis <[email protected]>
@markusicu
Copy link
Member

Hacks tend to beget hacks, in this case see PR #115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants