Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: publish the JSP docker image via github #1007

Closed
srl295 opened this issue Jan 28, 2025 · 1 comment · Fixed by #1008
Closed

feat: publish the JSP docker image via github #1007

srl295 opened this issue Jan 28, 2025 · 1 comment · Fixed by #1008
Assignees
@srl295

Comments

@srl295
Copy link
Member

srl295 commented Jan 28, 2025

https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry

we already build the docker image here

https://github.com/unicode-org/unicodetools/blob/main/.github/workflows/build-jsp.yml#L76-L77

so just need to push it to the container registry
@srl295 srl295 self-assigned this Jan 28, 2025
@srl295
Copy link
Member Author

srl295 commented Jan 28, 2025

this could in the meantime give people another way to easily run the latest locally per #1004

@srl295 srl295 mentioned this issue Jan 28, 2025
Open
srl295 added a commit to srl295/unicodetools that referenced this issue Jan 28, 2025
@srl295
feat: publish the JSP docker image via github
3910155 
For unicode-org#1007
srl295 added a commit to srl295/unicodetools that referenced this issue Jan 28, 2025
@srl295
feat: publish the JSP docker image via github
014bb53 
For unicode-org#1007
@srl295 srl295 mentioned this issue Jan 28, 2025
Merged
srl295 added a commit to srl295/unicodetools that referenced this issue Jan 28, 2025
@srl295
jsp: If on a PR, just do a Docker build to make sure we can.
520cfd1 
- push only on a tag (which will have the right creds)

unicode-org#1007
srl295 added a commit that referenced this issue Jan 28, 2025
@srl295
feat: publish the JSP docker image via github
1583ca8 
For #1007
srl295 added a commit that referenced this issue Jan 28, 2025
@srl295
jsp: If on a PR, just do a Docker build to make sure we can.
383be3a 
- push only on a tag (which will have the right creds)

#1007
@srl295 srl295 mentioned this issue Jan 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srl295 srl295

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

jsp: publish Docker Image to Github Packages on tag srl295/unicodetools
1 participant
@srl295