Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IS_BETA is fragile #101

Closed
srl295 opened this issue Jul 16, 2021 · 1 comment
Closed

IS_BETA is fragile #101

srl295 opened this issue Jul 16, 2021 · 1 comment
Assignees
@srl295

Comments

@srl295
Copy link
Member

srl295 commented Jul 16, 2021 

    public static final boolean IS_BETA = false;

What that does is turn on code that allows both ICU plus the beta data to be accessed,

It seems brittle to hardcode this; someone "in the know" needs to remember to toggle it when appropriate.
Why not compute it by comparing the current UCD.Settings version with ICU's UCharacter.getUnicodeVersion()?
@srl295 srl295 self-assigned this Jul 16, 2021
@markusicu markusicu mentioned this issue Nov 29, 2021
Closed
srl295 added a commit that referenced this issue Nov 29, 2021
@srl295
Turn off IS_BETA
5b6af1c 
- at least until #101 is done

For #140
@srl295 srl295 mentioned this issue Nov 29, 2021
Merged
srl295 added a commit that referenced this issue Dec 1, 2021
@srl295
Turn off IS_BETA (#170)
58d814e 
- at least until #101 is done

For #140
@eggrobin
Copy link
Member

Made obsolete by #659.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srl295 srl295

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srl295 @eggrobin