Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What are /bin-props/? #103

Closed
srl295 opened this issue Jul 20, 2021 · 4 comments · Fixed by #93
Closed

What are /bin-props/? #103

srl295 opened this issue Jul 20, 2021 · 4 comments · Fixed by #93
Assignees
@srl295

Comments

@srl295
Copy link
Member

srl295 commented Jul 20, 2021

ListProps.java has the following:

                    latest.internalStoreCachedMap(Settings.Output.GEN_DIR + "/bin-props/", item, map);

bin-props never appears anywhere else in the code, and running ListProps fails because this directory doesn't exist.

What does it mean? @macchiati ?
@srl295 srl295 added the question Further information is requested label Jul 20, 2021
@srl295 srl295 self-assigned this Jul 20, 2021
@srl295
Copy link
Member Author

srl295 commented Jul 20, 2021

Actually it looks like it was just missing a mkdir

@srl295 srl295 removed the question Further information is requested label Jul 20, 2021
@macchiati
Copy link
Member

macchiati commented Jul 20, 2021 via email •
edited by markusicu
Loading

@markusicu
Copy link
Member

I suspect that that wants to be changed to

latest.internalStoreCachedMap(Settings.Output.BIN_DIR, item, map);

where BIN_DIR = GEN_DIR + "BIN/"
unless it has to be separate from the regular BIN dir.

srl295 added a commit that referenced this issue Jul 20, 2021
@srl295
mkdir to fix #103
9264c9a
@srl295 srl295 mentioned this issue Jul 20, 2021
Merged
srl295 added a commit that referenced this issue Jul 20, 2021
@srl295
different fix for #103 changes data
73f1434
@srl295
Copy link
Member Author

srl295 commented Jul 20, 2021

I suspect that that wants to be changed to

latest.internalStoreCachedMap(Settings.Output.BIN_DIR, item, map);

where BIN_DIR = GEN_DIR + "BIN/"
unless it has to be separate from the regular BIN dir.

I can do that… that changes the binary data output! 

srl295 added a commit that referenced this issue Jul 20, 2021
@srl295
different fix for #103 changes data
c9461c5
srl295 added a commit that referenced this issue Jul 21, 2021
@srl295 @markusicu
bump JSP to Unicode 14 (#93)
122b9b9 
* jsp: to Beta 14.0.0 data (cut 1)

Step 1a text files
For #88
- GenerateSubtagNames
- Extra{Property,PropertyValue}Aliases.txt
- PropertyAliases.txt from 14.0.0
- copied props with CopyPropsToUnicodeJsp

* use beta

* make up scriptCodes for unrecognized scripts

- leave some space between ICU and collections such as Hans
- replace some synchornized and static init with Bill Pugh singletons

for #88

* mkdir to fix #103

* Add UpdateJspFiles to update all JSP files.

- updated docs

For: #88

* re-run UpdateJspFiles for U14.0.0

For: #88

* different fix for #103 changes data

* Updates per review comments

- typo/tab fixes
- add a unit test for Settings.UnicodeTools.DataDir
- Apply other suggestions from code review

Co-authored-by: Markus Scherer <[email protected]>

Co-authored-by: Markus Scherer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srl295 srl295

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bump JSP to Unicode 14 unicode-org/unicodetools
3 participants
@srl295 @macchiati @markusicu