Adding missing size_hint for UnicodeSentences, UnicodeWords, and UnicodeWordIndices #128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't expect this to noticeably impact performance either positively or negatively for most use-cases, especially because
Iterator::collect
relies on the lower bound ofsize_hint
which will remain unchanged after this PR.However the upper bound will go from
None
toSome(upper)
, which may benefit downstream crates that use it as a heuristic for pre-allocation size.Note also that I forwarded the implementation of
size_hint
to the inner iterator, which means it is UAX#29 agnostic. I'm not enough of a Unicode expert to know if e.g. word boundaries can be empty, so it may not be the tightest possible upper bound for longer strings.