configure: update .h for clock_adjtime #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clan
added a commit
to clan/gentoo
that referenced
this pull request
Jan 13, 2025
1. patch submitted to upstream at unicorn-engine/unicorn#2085 2. malloc_trim is not available on musl only Closes: https://bugs.gentoo.org/906919 Signed-off-by: Z. Liu <[email protected]>
4 tasks
|
include <sys/timex.h> works for musl, but not for glibc, checking why, although "man clock_adjtime" said so |
clan
added a commit
to clan/gentoo
that referenced
this pull request
Jan 13, 2025
1. patch submitted to upstream at unicorn-engine/unicorn#2085 2. malloc_trim is not available on musl only Closes: https://bugs.gentoo.org/906919 Signed-off-by: Z. Liu <[email protected]>
|
Thanks for your interest but the patch shall go to dev branch. |
for glibc, if _GNU_SOURCE is defined, <time.h> will include <sys/timex.h> but not for musl, so add "#include <sys/timex.h>" although `man clock_adjtime` said "#include <sys/timex.h>", but it won't work for glibc w/o "#include <time.h>", I don't known why yet. PS it seems clock_adjtime is used nowhere? Signed-off-by: Z. Liu <[email protected]>
ok, I'll fix this |
|
Thanks! |
clan
added a commit
to clan/gentoo
that referenced
this pull request
Jan 14, 2025
1. patch merged by upstream at unicorn-engine/unicorn#2085 2. malloc_trim is not available on musl only Closes: https://bugs.gentoo.org/906919 Signed-off-by: Z. Liu <[email protected]>
hyunmin-furiosa
pushed a commit
to hyunmin-furiosa/unicorn
that referenced
this pull request
Jan 17, 2025
…e#2085) for glibc, if _GNU_SOURCE is defined, <time.h> will include <sys/timex.h> but not for musl, so add "#include <sys/timex.h>" although `man clock_adjtime` said "#include <sys/timex.h>", but it won't work for glibc w/o "#include <time.h>", I don't known why yet. PS it seems clock_adjtime is used nowhere? Signed-off-by: Z. Liu <[email protected]>
clan
added a commit
to clan/gentoo
that referenced
this pull request
Jan 20, 2025
1. patch merged by upstream at unicorn-engine/unicorn#2085 2. malloc_trim is not available on musl only Closes: https://bugs.gentoo.org/906919 Signed-off-by: Z. Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
man clock_adjtime: #include <sys/timex.h>
for glibc, if _GNU_SOURCE is defined, <time.h> will include <sys/timex.h> but not for musl, so replce <time.h> to <sys/timex.h>
PS it seems clock_adjtime is used nowhere?