Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23 remove quantumtranslator references #31

Merged
merged 7 commits into from
Sep 27, 2024

Conversation

jordandsullivan
Copy link
Collaborator

Removing QuantumTranslator module and code which references it. Also cleared contents of notebooks as best practice.

@jordandsullivan jordandsullivan linked an issue Sep 25, 2024 that may be closed by this pull request
Copy link
Member

@natestemen natestemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It looks like the QuantumTranslator class wasn't being used anywhere in the module (I didn't have a look through all the notebooks).

@jordandsullivan jordandsullivan requested review from natestemen and removed request for Misty-W September 26, 2024 22:38
@natestemen
Copy link
Member

@jordandsullivan did you mean to request my review again?

@jordandsullivan
Copy link
Collaborator Author

@natestemen no, not intentional. I just haven't fixed the merge changes yet bc I'm running benchmarks locally in a different branch #2 .

@jordandsullivan jordandsullivan merged commit bf73af0 into main Sep 27, 2024
@jordandsullivan jordandsullivan deleted the 23-remove-quantumtranslator-references branch November 6, 2024 00:11
jordandsullivan added a commit that referenced this pull request Nov 13, 2024
…eferences

23 remove quantumtranslator references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove QuantumTranslator references
2 participants