Removing extraneous code for MVP #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanshammah
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
LGTM. Just consider whether keeping the name "custom_compile_heisenberg_..." or just "heisenberg_...", etc. in the benchmarks folder. I guess the reason for the name is the inheritance from qiskit/benchpress, but this could just be explained in a readme or/and docstring or/and documentation, while the file name could be kept a bit cleaner.
|
I think we most likely won't need to keep these files in the launch version, just wanted to keep them around for now just for easy prototyping. |
jordandsullivan
added a commit
that referenced
this pull request
Nov 13, 2024
Removing extraneous code for MVP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing extraneous code for MVP version. mvp branch will be merged into main and https://github.com/unitaryfund/ucc/tree/dev0.1 will be maintained as an archive of our development so far.