Move and expand test for logical equivalence #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test moved to test_compile.py
Test moved to test_compile.py
There was a problem hiding this comment.
I'm not sure we need quite so many tests personally with the varied small numbers of qubits, as it does extend the runtime to about a minute on my device. But it's not blocking for me. Either way, good to have these parameterized to make it easier to add other circuits later if desired.
natestemen
approved these changes
Nov 26, 2024
Remove unnecessary qubit parameterizations in `test_compiled_circuits_equivalent` and `test_compilation_retains_gateset`
|
thanks Jordan and Nate! I pared them down slightly before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved equivalence test from test_circuit_equivalence.py to test_compile.py.
Deleted test_circuit_equivalence.py as its only test function was moved.
Testing random Clifford and QCNN circuits w/ parametrized numbers of qubits and random seeds.