add basic expectation value benchmark #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natestemen
force-pushed
the
nts-expval-benchmark
branch
from
9fd2c9d to
c1989ba
Compare
|
@jordandsullivan I've made the changes we discussed today during standup. Ready for review 🫡. |
|
Okay because the way you were storing data was different than the existing benchmarks, I did some reorganizing of the results and updated some naming conventions: https://github.com/unitaryfund/ucc/tree/97-reorg-files I'm not sure the best practice for merging everything into main, but #97 should contain everything here and the data format updates. |
Merge this PR (if it's approved), then open a PR for your commits on top of it? No strong feelings.
JSON usually makes more sense to me since this avoids manipulating lists of data, but I agree it's best to have everything in the same format. Thanks for working on it! |
jordandsullivan
added a commit
that referenced
this pull request
Dec 3, 2024
* Move and expand test for logical equivalence Test moved to test_compile.py * Delete test_circuit_equivalence.py Test moved to test_compile.py * Remove unnecessary qubit parameterizations Remove unnecessary qubit parameterizations in `test_compiled_circuits_equivalent` and `test_compilation_retains_gateset` * add basic expectation value benchmark (#96) * add basic expectation value benchmark * move compile function to `common.py` * write data out to json * make data pipeline more functional * simplify real check * Add bug label to new bug report issues * Add feature tag to feature template issues * 97 reorg files (#98) * add basic expectation value benchmark * move compile function to `common.py` * write data out to json * make data pipeline more functional * simplify real check * Update naming convention for different benchmarks * Dry up save results into common function * Fix init import issue * Move gate_counters into scripts/common.py for simplicity * Fix notebook errors, remove old data * Remove duplicate funciton definitions * Remove duplicate lines * Add folder to docstring, call out alterntive benchmark name --------- Co-authored-by: nate stemen <[email protected]> --------- Co-authored-by: Misty-W <[email protected]> Co-authored-by: nate stemen <[email protected]>
jordandsullivan
added a commit
that referenced
this pull request
Dec 3, 2024
* Move and expand test for logical equivalence Test moved to test_compile.py * Delete test_circuit_equivalence.py Test moved to test_compile.py * Remove unnecessary qubit parameterizations Remove unnecessary qubit parameterizations in `test_compiled_circuits_equivalent` and `test_compilation_retains_gateset` * add basic expectation value benchmark (#96) * add basic expectation value benchmark * move compile function to `common.py` * write data out to json * make data pipeline more functional * simplify real check * Add bug label to new bug report issues * Add feature tag to feature template issues * 97 reorg files (#98) * add basic expectation value benchmark * move compile function to `common.py` * write data out to json * make data pipeline more functional * simplify real check * Update naming convention for different benchmarks * Dry up save results into common function * Fix init import issue * Move gate_counters into scripts/common.py for simplicity * Fix notebook errors, remove old data * Remove duplicate funciton definitions * Remove duplicate lines * Add folder to docstring, call out alterntive benchmark name --------- Co-authored-by: nate stemen <[email protected]> --------- Co-authored-by: Misty-W <[email protected]> Co-authored-by: nate stemen <[email protected]>
jordandsullivan
added a commit
that referenced
this pull request
Dec 3, 2024
* Move and expand test for logical equivalence Test moved to test_compile.py * Delete test_circuit_equivalence.py Test moved to test_compile.py * Remove unnecessary qubit parameterizations Remove unnecessary qubit parameterizations in `test_compiled_circuits_equivalent` and `test_compilation_retains_gateset` * add basic expectation value benchmark (#96) * add basic expectation value benchmark * move compile function to `common.py` * write data out to json * make data pipeline more functional * simplify real check * Add bug label to new bug report issues * Add feature tag to feature template issues * 97 reorg files (#98) * add basic expectation value benchmark * move compile function to `common.py` * write data out to json * make data pipeline more functional * simplify real check * Update naming convention for different benchmarks * Dry up save results into common function * Fix init import issue * Move gate_counters into scripts/common.py for simplicity * Fix notebook errors, remove old data * Remove duplicate funciton definitions * Remove duplicate lines * Add folder to docstring, call out alterntive benchmark name --------- Co-authored-by: nate stemen <[email protected]> --------- Co-authored-by: Misty-W <[email protected]> Co-authored-by: nate stemen <[email protected]>
jordandsullivan
added a commit
that referenced
this pull request
Dec 3, 2024
* Initial dockerfile, breaking out requirements. * Install requirements in Dockerfile, add -e pip flag * Automated deploy script to AWS * merge in new shell script changes (#104) * Move and expand test for logical equivalence Test moved to test_compile.py * Delete test_circuit_equivalence.py Test moved to test_compile.py * Remove unnecessary qubit parameterizations Remove unnecessary qubit parameterizations in `test_compiled_circuits_equivalent` and `test_compilation_retains_gateset` * add basic expectation value benchmark (#96) * add basic expectation value benchmark * move compile function to `common.py` * write data out to json * make data pipeline more functional * simplify real check * Add bug label to new bug report issues * Add feature tag to feature template issues * 97 reorg files (#98) * add basic expectation value benchmark * move compile function to `common.py` * write data out to json * make data pipeline more functional * simplify real check * Update naming convention for different benchmarks * Dry up save results into common function * Fix init import issue * Move gate_counters into scripts/common.py for simplicity * Fix notebook errors, remove old data * Remove duplicate funciton definitions * Remove duplicate lines * Add folder to docstring, call out alterntive benchmark name --------- Co-authored-by: nate stemen <[email protected]> --------- Co-authored-by: Misty-W <[email protected]> Co-authored-by: nate stemen <[email protected]> * Update PyTKET rebase pass --------- Co-authored-by: Misty-W <[email protected]> Co-authored-by: nate stemen <[email protected]>
jordandsullivan
added a commit
that referenced
this pull request
Dec 3, 2024
* remove unnecessary script * merge in recent changes from main (#106) * Move and expand test for logical equivalence Test moved to test_compile.py * Delete test_circuit_equivalence.py Test moved to test_compile.py * Remove unnecessary qubit parameterizations Remove unnecessary qubit parameterizations in `test_compiled_circuits_equivalent` and `test_compilation_retains_gateset` * add basic expectation value benchmark (#96) * add basic expectation value benchmark * move compile function to `common.py` * write data out to json * make data pipeline more functional * simplify real check * Add bug label to new bug report issues * Add feature tag to feature template issues * 97 reorg files (#98) * add basic expectation value benchmark * move compile function to `common.py` * write data out to json * make data pipeline more functional * simplify real check * Update naming convention for different benchmarks * Dry up save results into common function * Fix init import issue * Move gate_counters into scripts/common.py for simplicity * Fix notebook errors, remove old data * Remove duplicate funciton definitions * Remove duplicate lines * Add folder to docstring, call out alterntive benchmark name --------- Co-authored-by: nate stemen <[email protected]> --------- Co-authored-by: Misty-W <[email protected]> Co-authored-by: nate stemen <[email protected]> * merge in main (#107) * Move and expand test for logical equivalence Test moved to test_compile.py * Delete test_circuit_equivalence.py Test moved to test_compile.py * Remove unnecessary qubit parameterizations Remove unnecessary qubit parameterizations in `test_compiled_circuits_equivalent` and `test_compilation_retains_gateset` * add basic expectation value benchmark (#96) * add basic expectation value benchmark * move compile function to `common.py` * write data out to json * make data pipeline more functional * simplify real check * Add bug label to new bug report issues * Add feature tag to feature template issues * 97 reorg files (#98) * add basic expectation value benchmark * move compile function to `common.py` * write data out to json * make data pipeline more functional * simplify real check * Update naming convention for different benchmarks * Dry up save results into common function * Fix init import issue * Move gate_counters into scripts/common.py for simplicity * Fix notebook errors, remove old data * Remove duplicate funciton definitions * Remove duplicate lines * Add folder to docstring, call out alterntive benchmark name --------- Co-authored-by: nate stemen <[email protected]> --------- Co-authored-by: Misty-W <[email protected]> Co-authored-by: nate stemen <[email protected]> * Delete benchmarks/scripts/deploy_benchmark_task.py No longer needed, build-spec lives on AWS * remove unnecessary .gitignore line --------- Co-authored-by: Misty-W <[email protected]> Co-authored-by: nate stemen <[email protected]>
jordandsullivan
added a commit
that referenced
this pull request
Dec 6, 2024
* Add a couple comments, correct typo * Add final basis set remapping step to transpilation when passed a Qiskit backend * First hardware benchmark notebook * merge in main (#109) * Initial dockerfile, breaking out requirements. * Install requirements in Dockerfile, add -e pip flag * Automated deploy script to AWS * merge in new shell script changes (#104) * Move and expand test for logical equivalence Test moved to test_compile.py * Delete test_circuit_equivalence.py Test moved to test_compile.py * Remove unnecessary qubit parameterizations Remove unnecessary qubit parameterizations in `test_compiled_circuits_equivalent` and `test_compilation_retains_gateset` * add basic expectation value benchmark (#96) * add basic expectation value benchmark * move compile function to `common.py` * write data out to json * make data pipeline more functional * simplify real check * Add bug label to new bug report issues * Add feature tag to feature template issues * 97 reorg files (#98) * add basic expectation value benchmark * move compile function to `common.py` * write data out to json * make data pipeline more functional * simplify real check * Update naming convention for different benchmarks * Dry up save results into common function * Fix init import issue * Move gate_counters into scripts/common.py for simplicity * Fix notebook errors, remove old data * Remove duplicate funciton definitions * Remove duplicate lines * Add folder to docstring, call out alterntive benchmark name --------- Co-authored-by: nate stemen <[email protected]> --------- Co-authored-by: Misty-W <[email protected]> Co-authored-by: nate stemen <[email protected]> * Update PyTKET rebase pass --------- Co-authored-by: Misty-W <[email protected]> Co-authored-by: nate stemen <[email protected]> * Real hardware benchmark * Remove unrelated file * Remove unnecessary .gitignore line --------- Co-authored-by: Misty-W <[email protected]> Co-authored-by: nate stemen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #66
Review notes
cirq_compile,qiskit_compile, andpytket_compile. Should I DRY this up by moving it tocommon.py?