Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve extending github layers #109

Merged
merged 4 commits into from
Oct 9, 2023
Merged

feat: improve extending github layers #109

merged 4 commits into from
Oct 9, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Oct 9, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR improves extending behavior for GitHub layers by preferring to clone to local node_modules/.c12/{id}. This way layers can share the same dependencies of the main project.

Other improvements:

  • Cloned layer names are explicitly hashed using ohash. This resolves issues when cloning from same github remote but different directories when it was possible to conflict cache
  • Supported gh: shorthand

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title feat/clone fixes feat: improve extending github layers Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #109 (34f95eb) into main (7940e9b) will increase coverage by 0.37%.
Report is 1 commits behind head on main.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   77.55%   77.93%   +0.37%     
==========================================
  Files           5        5              
  Lines         704      716      +12     
  Branches       63       64       +1     
==========================================
+ Hits          546      558      +12     
  Misses        158      158              
Files Coverage Ξ”
src/loader.ts 90.18% <91.66%> (+0.38%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant