feat(git): support parse git messages that have prefix emoji #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
Although not part of the
conventionalcommits
standard, it is common practice for git messages to be prefixed with emoji.This PR allows parsing prefixed string emoji (e.g.,
:bug:
) and Unicode emoji (e.g., 🐞).I ran unit tests to make sure it wouldn't affect the original parsing. I also wrote the appropriate unit tests for emoji parsing.
Need for discussion
Theoretically, unless someone uses emoji to prevent commits from being added to the changelog, it's senseless. So I just modified the original regex.
If we must obey
conventionalcommits
, we may need to expose the regex to config.📝 Checklist