Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(parse): support filter option for key filtering #35

Merged
merged 2 commits into from
May 22, 2024
Merged

feat(parse): support filter option for key filtering #35

merged 2 commits into from
May 22, 2024

Conversation

yxw007
Copy link
Contributor

@yxw007 yxw007 commented May 22, 2024 •
edited by danielroe
Loading

πŸ”— Linked issue

nuxt/nuxt#27246
resolves #31

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adopt a better way to solve nuxt/nuxt#27246 issue
More discussion：#32

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title feat: parse adds the filter function to support filtering feat(parse): support filter option for key filtering May 22, 2024
pi0
pi0 reviewed May 22, 2024
View reviewed changes
src/types.ts Outdated Show resolved Hide resolved
pi0
pi0 approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❀️

@pi0 pi0 merged commit f7c9a14 into unjs:main May 22, 2024
0 of 2 checks passed
@pi0 pi0 mentioned this pull request May 22, 2024
Closed
@yxw007
Copy link
Contributor Author

yxw007 commented May 22, 2024

Thank you ❀️

It's my pleasure to help with the code, and I appreciate your guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parsing single cookie
2 participants
@yxw007 @pi0