Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sourcemap generation support #164

Open
pi0 opened this issue Jul 18, 2023 · 0 comments · May be fixed by #276
Open

Sourcemap generation support #164

pi0 opened this issue Jul 18, 2023 · 0 comments · May be fixed by #276
Labels
enhancement New feature or request

Comments

@pi0
Copy link
Member

pi0 commented Jul 18, 2023

No description provided.

This was referenced Jul 18, 2023
Merged
Closed
@pi0 pi0 added the enhancement New feature or request label Jan 21, 2024
bryan-hoang added a commit to bryan-hoang/mkdist that referenced this issue Dec 20, 2024
@bryan-hoang
feat: add support for generating sourcemaps
0c1244d 
The CLI now accepts a `--sourcemap` option that should match the
behaviour of esbuild's `--sourcemap` option. The programmatic API's
`esbuild.sourcemap` option should now also match with `esbuild`'s
`sourcemap` option for the Build API [^1].

Resolves unjs#164

[^1]: `sourcemap: 'linked'` is special cased in the code since
  `esbuild` doesn't support the option under the Transform API that
  `mkdist` uses.
bryan-hoang added a commit to bryan-hoang/mkdist that referenced this issue Dec 20, 2024
@bryan-hoang
feat: add support for generating sourcemaps
ecaf49f 
The CLI now accepts a `--sourcemap` option that should match the
behaviour of esbuild's `--sourcemap` option. The programmatic API's
`esbuild.sourcemap` option should now also match with `esbuild`'s
`sourcemap` option for the Build API.

The `sourcemap: 'linked'` option is special cased in the implementation
since `esbuild` doesn't support the option under the Transform API that
`mkdist` uses [^1].

Resolves unjs#164

Refs: https://esbuild.github.io/api/#sourcemap
Refs: https://sourcemaps.info/spec.html

[^1]: https://github.com/evanw/esbuild/blob/745abd9f0c06f73ca40fbe198546a9bc36c23b81/pkg/api/api_impl.go#L1749
bryan-hoang added a commit to bryan-hoang/mkdist that referenced this issue Dec 20, 2024
@bryan-hoang
feat: add support for generating sourcemaps
f9d2746 
The CLI now accepts a `--sourcemap` option that should match the
behaviour of `esbuild`'s `--sourcemap` option. The programmatic API's
`esbuild.sourcemap` option should now also match with `esbuild`'s
`sourcemap` option for the Build API.

The `sourcemap: 'linked'` option is special cased in the implementation,
since `esbuild` doesn't support the option under the Transform API that
`mkdist` uses [^1].

Resolves unjs#164

Refs: https://esbuild.github.io/api/#sourcemap
Refs: https://sourcemaps.info/spec.html

[^1]: https://github.com/evanw/esbuild/blob/745abd9f0c06f73ca40fbe198546a9bc36c23b81/pkg/api/api_impl.go#L1749
@bryan-hoang bryan-hoang linked a pull request Dec 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for generating sourcemaps bryan-hoang/mkdist
1 participant
@pi0