-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to install dependencies with a frozen lockfile #121
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
- Coverage 82.17% 72.51% -9.66%
==========================================
Files 6 6
Lines 516 655 +139
Branches 71 85 +14
==========================================
+ Hits 424 475 +51
- Misses 91 177 +86
- Partials 1 3 +2 β View full report in Codecov by Sentry. |
The root error in CI seems to be this failing test that only failed on windows. The second test that failed errored because it depended on this test succeeding.
I checked locally on my windows machine if this was a reproducible problem and it doesn't seem to be. The internet seems to consider this error as ephemeral and solved by deleting I'm inclined to rerun the action because of this and the install command isn't run on the workspace fixtures. What do you think @pi0? Also, I'd be happy to add install tests to the workspace tests. Given their lack, I wanted to see what the reasoning was for there not being any before adding them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. windows CI seems to be passing now!
π Linked issue
Closes #115
β Type of change
π Description
Closes #115
π Checklist