-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf!: replace execa
with tinyexec
#151
Conversation
Actually, since there are only two usages, we could just use |
execa
with tinyexec
Thanks for PR. I think so we might directly use Nypm was doing this before. We moved to execa to support cross-platform search path of Since this change might introduce regression, i am thinking more about options we have. |
No rush! No matter which solution you decide on, I'm happy to help driving this replacement forward. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
===========================================
- Coverage 82.17% 63.40% -18.77%
===========================================
Files 6 5 -1
Lines 516 470 -46
Branches 71 84 +13
===========================================
- Hits 424 298 -126
- Misses 91 169 +78
- Partials 1 3 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it for nypm 0.4.x in meantime!
execa
with tinyexec
Resolves #150.
This PR is a suggestion to replace heavier
execa
with a lightertinyexec
to reduce the dependency count and the bundle size.