fix(removeRoute): remove named wildcard routes (#137)

* fix #136 * Update test/router.test.ts --------- Co-authored-by: Pooya Parsa <[email protected]>
unjs · Sep 19, 2024 · 379cfb6 · 379cfb6
1 parent 87f7125
commit 379cfb6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/operations/remove.ts b/src/operations/remove.ts
@@ -43,7 +43,7 @@ function _remove(
   }
 
   // Wildcard
-  if (segment === "**") {
+  if (segment.startsWith("**")) {
     if (node.wildcard) {
       _remove(node.wildcard, method, segments, index + 1);
       if (_isEmptyNode(node.wildcard)) {

diff --git a/test/router.test.ts b/test/router.test.ts
@@ -506,4 +506,14 @@ describe("Router remove", function () {
       params: { _: "components/snackbars" },
     });
   });
+
+  it("remove named wildcard routes", function () {
+    const route = "/user/**:id";
+    const router = createRouter([route]);
+
+    removeRoute(router, "GET", route);
+
+    expect(findRoute(router, "GET", "/user/123")).toBeUndefined();
+    expect(findRoute(router, "GET", "/user/wildcard")).toBeUndefined();
+  });
 });