fix: filter commonjs plugin when generating declaration (#495)

unjs · Feb 26, 2025 · c915342 · c915342
1 parent 74af8d0
commit c915342
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/src/builders/rollup/build.ts b/src/builders/rollup/build.ts
@@ -83,7 +83,15 @@ export async function rollupBuild(ctx: BuildContext): Promise<void> {
       dts(ctx.options.rollup.dts),
       removeShebangPlugin(),
       ctx.options.rollup.emitCJS && fixCJSExportTypePlugin(),
-    ].filter(Boolean);
+    ].filter(
+      (plugin) =>
+        /**
+         * Issue: #396
+         * rollup-plugin-dts conflicts with rollup-plugin-commonjs:
+         * https://github.com/Swatinem/rollup-plugin-dts?tab=readme-ov-file#what-to-expect
+         */
+        plugin && (!("name" in plugin) || plugin.name !== "commonjs"),
+    );
 
     await ctx.hooks.callHook("rollup:dts:options", ctx, rollupOptions);
     const typesBuild = await rollup(rollupOptions);