Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always remove file extension by default in toTypeDeclarationItems #303

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

productdevbook
Copy link
Contributor

@productdevbook productdevbook commented Dec 5, 2023

function

πŸ”— Linked issue

close atinux/nuxt-auth-utils#1
close nuxt/nuxt#24445

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

It was not working because it included ext when creating dts. This should solve the problem.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@productdevbook
Copy link
Contributor Author

I've completely corrected the tests now

@productdevbook
Copy link
Contributor Author

Hi @antfu :) I don't know if pinging is right. If pinging is wrong, warn me.

@antfu antfu changed the title fix: file path regex in toTypeDeclarationItems fix: always remove file extension by default in toTypeDeclarationItems Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (d9ab710) 98.22% compared to head (4fee9f8) 98.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #303   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files          57       57           
  Lines        1518     1518           
  Branches      298      298           
=======================================
  Hits         1491     1491           
  Misses         27       27           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@antfu
Copy link
Member

antfu commented Dec 6, 2023

Thanks for the PR. And yeah it's better to not pinging unless it's urgent or being inactive for a very long time. Maintainers have their own pace to go through PRs/issues one by one. Thank you.

@antfu antfu merged commit 7ec41c2 into unjs:main Dec 6, 2023
5 checks passed
@productdevbook productdevbook deleted the fix-dts-exp branch December 6, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong type import when using addServerImportsDir in module Types not correctly imported
2 participants