Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: to handle module file extensions in toTypeDeclarationItems function #319

Closed
wants to merge 2 commits into from

Conversation

productdevbook
Copy link
Contributor

@productdevbook productdevbook commented Jan 22, 2024

🔗 Linked issue

#306

  const connectPostgresJS: typeof import('../../../../node_modules/.pnpm/@[email protected][email protected][email protected][email protected][email protected]/node_modules/@pergel/nuxt/dist/runtime/modules/drizzle/drivers/postgres/export.mjs')['connectPostgresJS']

fixed pr

  const connectPostgresJS: typeof import('../../../../node_modules/.pnpm/@[email protected][email protected][email protected][email protected][email protected]/node_modules/@pergel/nuxt/dist/runtime/modules/drizzle/drivers/postgres/export')['connectPostgresJS']

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@danielroe danielroe requested a review from antfu January 22, 2024 19:00
@antfu
Copy link
Member

antfu commented Jan 23, 2024

Won't that be possible to do it in the resolvePath function pass-in? The same reason of #306, I think it's better for unimport to not introduce implicit conversion that users are not able to control.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@productdevbook
Copy link
Contributor Author

productdevbook commented Jan 25, 2024

Yes, thats true. I am change refactor. Since Nuxt Source sends resolvePath, I automatically set the new structure to a default true structure. Please check.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4103e4e) 98.73% compared to head (42857a8) 98.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   98.73%   98.74%   +0.01%     
==========================================
  Files          14       14              
  Lines        1815     1837      +22     
  Branches      369      372       +3     
==========================================
+ Hits         1792     1814      +22     
  Misses         23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@productdevbook
Copy link
Contributor Author

nitrojs/nitro#2139. I solved the problem with nitro. I don't need this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants