Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update codecov config #398

Closed
wants to merge 1 commit into from
Closed

chore: update codecov config #398

wants to merge 1 commit into from

Conversation

noootwo
Copy link
Contributor

@noootwo noootwo commented Nov 29, 2024

Lower the code coverage configuration of codecov

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.65%. Comparing base (a4a5e0a) to head (37a1bf7).
Report is 67 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
- Coverage   98.73%   97.65%   -1.09%     
==========================================
  Files          14       15       +1     
  Lines        1817     1448     -369     
  Branches      374      471      +97     
==========================================
- Hits         1794     1414     -380     
- Misses         23       34      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antfu
Copy link
Member

antfu commented Nov 30, 2024

Thanks, but I think the current setup is fine. I don't have a strong requirement on 100% coverage, but I think it's good to be aware the coverage will drop when merging PRs and find the balance manually.

@antfu antfu closed this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants