Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve error when visualizing recent shows #174

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

raffaeleterribile
Copy link

Change the source of the

Now that Channel 9 is merged with Microsoft Learn TV, the "Recent" tab shows an error.
I didn't find as RSS feed for the new site, so I resolved to use the endpoint to obtain the JSON file of the schedule, to parse it and to adapt the parsed results to the existing behaviour.
Tested only the UWP project.

PR Type

I've made these types of changes:

  • Bugfix
  • Feature
  • Build or CI related changes

What is the current behavior?

Get an RSS feed from the Channel 9 site.
Tested only the UWP project.

What is the new behavior?

Gets a JSON file with the scheduled shows from the Microsoft Learn TV site.

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x ] Tested code with current UWP
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • [x ] Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

@CLAassistant
Copy link

CLAassistant commented Apr 3, 2022

CLA assistant check
All committers have signed the CLA.

@francoistanguay
Copy link

This is amazing. Let us review. I also remember Scott Hanselman streaming about changing one of this projects to new APIs as these same ones were deprecated. Will try to find more info.

@francoistanguay
Copy link

Pretty sure it was this video. Maybe useful? https://www.youtube.com/watch?v=u9vHV_KpTC8&t=1520s

@raffaeleterribile
Copy link
Author

Pretty sure it was this video. Maybe useful? https://www.youtube.com/watch?v=u9vHV_KpTC8&t=1520s

Thanks! I'll check it

@raffaeleterribile
Copy link
Author

Pretty sure it was this video. Maybe useful? https://www.youtube.com/watch?v=u9vHV_KpTC8&t=1520s

Hi.

Sorry, I haven't time to work on this issue until now.
I've seen Scott Hanselman's video, but I'm not sure I can apply his trick.
In the video Scott explains that the original endpoint was split in two: one for the episodes of the show and one for the details of each episode.
But the "recent" endpoint of LearnTV shows episodes of several shows and there isn't a link to the show, there is a link to the page of the episode and I didn't find a way to extract the video url...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants